This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((jiol() || dinges() || !(esshen() || vidme() < lacsve())) && monlot() && !id && (twiar() || hobroc() || !streor())) {
...
...
// Pretend there is lots of code here
...
...
} else {
stas();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (streor() && !hobroc() && !twiar() || id || !monlot() || (esshen() || vidme() < lacsve()) && !dinges() && !jiol()) {
stas();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (ol || !ad || bospom() || cribia() || it && ka) {
if (gloud() >= 6) {
if (rekas() != 4) {
if (!ud) {
return true;
}
}
if (oanCosi()) {
return true;
}
}
}
return false;
return oanCosi() && (!ud || rekas() != 4) || gloud() >= 6 || ol || !ad || bospom() || cribia() || it && ka;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!it && !cribia() && !bospom() && ad && !ol && gloud() <= 6 && rekas() == 4 && ud || !oanCosi()) {
if (!oanCosi()) {
if (ud) {
return false;
}
if (rekas() == 4) {
return false;
}
}
if (gloud() <= 6) {
return false;
}
if (!ol) {
return false;
}
if (ad) {
return false;
}
if (!bospom()) {
return false;
}
if (!cribia()) {
return false;
}
if (!ka) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (!nang) {
nord();
}
if (os == true && nang) {
gogla();
}
if (fre == true && nang && os != true) {
seet();
} else if (cua && nang && os != true && fre != true) {
neifae();
} else if (dru == true && nang && os != true && fre != true && !cua) {
oolSenbi();
}
if (sio == 9 && nang && os != true && fre != true && !cua && dru != true) {
sesTreal();
}
if (dogn && nang && os != true && fre != true && !cua && dru != true && sio != 9) {
ilgla();
}
if (oc == true && nang && os != true && fre != true && !cua && dru != true && sio != 9 && !dogn) {
padpe();
} else if (nang && os != true && fre != true && !cua && dru != true && sio != 9 && !dogn && oc != true) {
psiho();
}
{
if (!nang) {
nord();
}
if (os) {
gogla();
}
if (fre) {
seet();
}
if (cua) {
neifae();
}
if (dru) {
oolSenbi();
}
if (sio == 9) {
sesTreal();
}
if (dogn) {
ilgla();
}
if (oc) {
padpe();
}
psiho();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: