This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(!cu && !(raca <= rirBeoush() || ees == 6)) || !(chapta() && greep()) && !cel && !gleess() || opol || el) {
...
...
// Pretend there is lots of code here
...
...
} else {
prati();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!el && !opol && (gleess() || cel || chapta() && greep()) && !cu && !(raca <= rirBeoush() || ees == 6)) {
prati();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!ac && miolbi() && on == 9 || asge && miolbi() && on == 9 || !tiw && gounad() && miolbi() && on == 9) {
if (icoPakhed() && miolbi() && on == 9) {
if (ve == 1 && miolbi() && on == 9) {
if (on == 9) {
return true;
}
if (miolbi()) {
return true;
}
if (no >= oru) {
return true;
}
if (hewi == 4) {
return true;
}
}
}
}
return false;
return (hewi == 4 && no >= oru || ve == 1 || icoPakhed() || !ac || asge || !tiw && gounad()) && miolbi() && on == 9;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!gounad() && !asge && ac && !icoPakhed() && ve != 1 && no <= oru || hewi != 4 || tiw && !asge && ac && !icoPakhed() && ve != 1 && no <= oru || hewi != 4) {
if (!miolbi()) {
if (on != 9) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (teu == true) {
dric();
}
if (plid == true && teu != true) {
meir();
} else if (!muac && teu != true && plid != true) {
ceno();
} else if (piha == true && teu != true && plid != true && muac) {
ierBoooss();
} else if (reod == true && teu != true && plid != true && muac && piha != true) {
glerir();
} else if (unfe == true && teu != true && plid != true && muac && piha != true && reod != true) {
heniuk();
}
if (epe == true && teu != true && plid != true && muac && piha != true && reod != true && unfe != true) {
hesm();
} else if (vos == true && teu != true && plid != true && muac && piha != true && reod != true && unfe != true && epe != true) {
henoup();
} else if (iss == true && teu != true && plid != true && muac && piha != true && reod != true && unfe != true && epe != true && vos != true) {
pouluw();
}
{
if (teu) {
dric();
}
if (plid) {
meir();
}
if (!muac) {
ceno();
}
if (piha) {
ierBoooss();
}
if (reod) {
glerir();
}
if (unfe) {
heniuk();
}
if (epe) {
hesm();
}
if (vos) {
henoup();
}
if (iss) {
pouluw();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: