This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((trat() || id) && !ac && plar() && pird() <= precu() || !(uider() && rodlen() != psa && tudTahest())) {
...
...
// Pretend there is lots of code here
...
...
} else {
padvi();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (uider() && rodlen() != psa && tudTahest() && (pird() >= precu() || !plar() || ac || !id && !trat())) {
padvi();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (liol) {
if (ocs && podeor() && poam() && crur() <= phe && piold() >= 8 || woesoc() && podeor() && poam() && crur() <= phe && piold() >= 8 || a == 7 && podeor() && poam() && crur() <= phe && piold() >= 8) {
if (piold() >= 8) {
return true;
}
if (crur() <= phe) {
return true;
}
if (poam()) {
return true;
}
if (u) {
return true;
}
}
}
return false;
return (u || (ocs || woesoc() || a == 7) && podeor()) && poam() && crur() <= phe && piold() >= 8 || liol;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!poam() || !podeor() && !u || a != 7 && !woesoc() && !ocs && !u) {
if (crur() >= phe) {
if (piold() <= 8) {
return false;
}
}
}
if (!liol) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (!hioo) {
ehis();
} else if (hiar != tre && hioo) {
iendo();
}
if (!ic && hioo && hiar == tre) {
sipi();
} else if (nass == true && hioo && hiar == tre && ic) {
antpa();
} else if (poo == true && hioo && hiar == tre && ic && nass != true) {
peco();
}
if (te <= dall && hioo && hiar == tre && ic && nass != true && poo != true) {
bunde();
} else if (nia && hioo && hiar == tre && ic && nass != true && poo != true && te >= dall) {
ecksac();
} else if (ro <= o && hioo && hiar == tre && ic && nass != true && poo != true && te >= dall && !nia) {
bappac();
}
{
if (!hioo) {
ehis();
}
if (hiar != tre) {
iendo();
}
if (!ic) {
sipi();
}
if (nass) {
antpa();
}
if (poo) {
peco();
}
if (te <= dall) {
bunde();
}
if (nia) {
ecksac();
}
if (ro <= o) {
bappac();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: