This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((xicgoo() < 3 || reng || ri) && !gashee() && pe && a < 5 && (!e || bauErp() == snoCer())) {
...
...
// Pretend there is lots of code here
...
...
} else {
ubler();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (bauErp() != snoCer() && e || a > 5 || !pe || gashee() || !ri && !reng && xicgoo() > 3) {
ubler();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (prus() == i && fe && achish() && he && !elfi && em == 9 || !lu && achish() && he && !elfi && em == 9) {
if (em == 9) {
return true;
}
if (!elfi) {
return true;
}
if (he) {
return true;
}
if (achish()) {
return true;
}
if (paham()) {
return true;
}
}
if (toc) {
return true;
}
return false;
return toc && (paham() || prus() == i && (fe || !lu)) && achish() && he && !elfi && em == 9;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!he || !achish() || lu && !fe && !paham() || prus() != i && !paham() || !toc) {
if (elfi) {
if (em != 9) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (nohi == true) {
sarst();
}
if (efla && nohi != true) {
redeus();
} else if (nocs == true && nohi != true && !efla) {
oenSenma();
}
if (onre == true && nohi != true && !efla && nocs != true) {
lidcia();
} else if (zis == true && nohi != true && !efla && nocs != true && onre != true) {
pouFreng();
} else if (cint == true && nohi != true && !efla && nocs != true && onre != true && zis != true) {
ussein();
} else if (puwi != sli && nohi != true && !efla && nocs != true && onre != true && zis != true && cint != true) {
speSomda();
}
if (nohi != true && !efla && nocs != true && onre != true && zis != true && cint != true && puwi == sli) {
chiad();
}
{
if (nohi) {
sarst();
}
if (efla) {
redeus();
}
if (nocs) {
oenSenma();
}
if (onre) {
lidcia();
}
if (zis) {
pouFreng();
}
if (cint) {
ussein();
}
if (puwi != sli) {
speSomda();
}
chiad();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: