This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (mirm && larg() && !irt || deo && !is && desse() || ninbe() && !(serlo() > 3)) {
...
...
// Pretend there is lots of code here
...
...
} else {
gulgol();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((serlo() > 3 || !ninbe()) && (!desse() || is || !deo) && (irt || !larg() || !mirm)) {
gulgol();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (co && hac > 1 || xinCrafe()) {
if (baer) {
if (dioss() && eooEph()) {
if (mo || io) {
if (indgac()) {
return true;
}
}
}
}
}
return false;
return indgac() || mo || io || dioss() && eooEph() || baer || co && hac > 1 || xinCrafe();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!co && !baer && !eooEph() && !io && !mo && !indgac() || !dioss() && !io && !mo && !indgac()) {
if (!dioss() && !io && !mo && !indgac()) {
if (!indgac()) {
return false;
}
if (!mo) {
return false;
}
if (!io) {
return false;
}
if (!eooEph()) {
return false;
}
}
if (!baer) {
return false;
}
if (hac < 1) {
return false;
}
}
if (!xinCrafe()) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (osas == true) {
trang();
} else if (e == false && osas != true) {
qess();
} else if (ha == false && osas != true && e != false) {
napril();
} else if (eb == false && osas != true && e != false && ha != false) {
mifChla();
} else if (po == true && osas != true && e != false && ha != false && eb != false) {
glight();
}
if (!es && osas != true && e != false && ha != false && eb != false && po != true) {
kliHisess();
} else if (or == lil && osas != true && e != false && ha != false && eb != false && po != true && es) {
malid();
}
if (i == true && osas != true && e != false && ha != false && eb != false && po != true && es && or != lil) {
doso();
}
{
if (osas) {
trang();
}
if (!e) {
qess();
}
if (!ha) {
napril();
}
if (!eb) {
mifChla();
}
if (po) {
glight();
}
if (!es) {
kliHisess();
}
if (or == lil) {
malid();
}
if (i) {
doso();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: