This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((moik || !(u == trugus()) || !(i >= euc && jie == mo && io <= meff)) && (ucdi < 0 && ewin() || psong())) {
...
...
// Pretend there is lots of code here
...
...
} else {
irhe();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!psong() && (!ewin() || ucdi > 0) || i >= euc && jie == mo && io <= meff && u == trugus() && !moik) {
irhe();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (hi && fopem() && funvas() || !ilhe && fopem() && funvas() || !ce) {
if (fo == 9) {
if (dri) {
return true;
}
}
if (stas()) {
return true;
}
if (brepe()) {
return true;
}
}
return false;
return brepe() && stas() && (dri || fo == 9) || (hi || !ilhe) && fopem() && funvas() || !ce;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (ilhe && !hi && fo != 9 && !dri || !stas() || !brepe()) {
if (!fopem() && fo != 9 && !dri || !stas() || !brepe()) {
if (!stas() || !brepe()) {
if (!dri) {
return false;
}
if (fo != 9) {
return false;
}
}
if (!funvas()) {
return false;
}
}
}
if (ce) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (ood == false) {
teisve();
}
if (pene == true && ood != false) {
secec();
}
if (reha == true && ood != false && pene != true) {
iliou();
} else if (deng && ood != false && pene != true && reha != true) {
eism();
}
if (bawe == true && ood != false && pene != true && reha != true && !deng) {
hioc();
} else if (!is && ood != false && pene != true && reha != true && !deng && bawe != true) {
phiail();
} else if (!we && ood != false && pene != true && reha != true && !deng && bawe != true && is) {
emin();
}
if (esmo == true && ood != false && pene != true && reha != true && !deng && bawe != true && is && we) {
wheJaca();
}
{
if (!ood) {
teisve();
}
if (pene) {
secec();
}
if (reha) {
iliou();
}
if (deng) {
eism();
}
if (bawe) {
hioc();
}
if (!is) {
phiail();
}
if (!we) {
emin();
}
if (esmo) {
wheJaca();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: