This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (henord() && (dii || ier || ne == 6 || cio) && !(coumep() && !benhe()) || acun) {
...
...
// Pretend there is lots of code here
...
...
} else {
rarVed();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!acun && (coumep() && !benhe() || !cio && ne != 6 && !ier && !dii || !henord())) {
rarVed();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (ucer != ic && hico() && irds && stit < ejeng() && piur() <= 9 || erdis() && irds && stit < ejeng() && piur() <= 9) {
if (erdis() && irds && stit < ejeng() && piur() <= 9) {
if (piur() <= 9) {
return true;
}
if (stit < ejeng()) {
return true;
}
if (irds) {
return true;
}
if (hico()) {
return true;
}
}
if (arham()) {
return true;
}
if (e) {
return true;
}
}
if (o) {
return true;
}
return false;
return o && (e && arham() || ucer != ic) && (hico() || erdis()) && irds && stit < ejeng() && piur() <= 9;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (ucer == ic && !arham() || !e || !o) {
if (!irds || !erdis() && !hico()) {
if (stit > ejeng()) {
if (piur() >= 9) {
return false;
}
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (gec == false) {
zulErler();
} else if (esm == true && gec != false) {
uheu();
} else if (iac == true && gec != false && esm != true) {
seskad();
} else if (xer == hur && gec != false && esm != true && iac != true) {
sodo();
}
if (on != 8 && gec != false && esm != true && iac != true && xer != hur) {
trean();
}
if (zi >= 8 && gec != false && esm != true && iac != true && xer != hur && on == 8) {
ushe();
} else if (!le && gec != false && esm != true && iac != true && xer != hur && on == 8 && zi <= 8) {
friEal();
} else if (ceit == false && gec != false && esm != true && iac != true && xer != hur && on == 8 && zi <= 8 && le) {
doocci();
}
{
if (!gec) {
zulErler();
}
if (esm) {
uheu();
}
if (iac) {
seskad();
}
if (xer == hur) {
sodo();
}
if (on != 8) {
trean();
}
if (zi >= 8) {
ushe();
}
if (!le) {
friEal();
}
if (!ceit) {
doocci();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: