This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((iu == 8 || tirn() || wi) && tiosmi() && pracma() != 6 && (iprit() != 0 || musje() || sqel)) {
...
...
// Pretend there is lots of code here
...
...
} else {
oent();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!sqel && !musje() && iprit() == 0 || pracma() == 6 || !tiosmi() || !wi && !tirn() && iu != 8) {
oent();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (rost && muce() || la == 1 && ad > anmon()) {
if (ceod && muce() || la == 1 && ad > anmon()) {
if (uirsa() && muce() || la == 1 && ad > anmon()) {
if (ninch() && muce() || la == 1 && ad > anmon() || quca && muce() || la == 1 && ad > anmon()) {
if (la == 1 && ad > anmon()) {
if (muce()) {
return true;
}
}
if (!mi) {
return true;
}
}
}
}
}
return false;
return (!mi || ninch() || quca || uirsa() || ceod || rost) && (muce() || la == 1 && ad > anmon());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!rost && !ceod && !uirsa() && !quca && !ninch() && mi) {
if (la != 1 && !muce()) {
if (!muce()) {
return false;
}
if (ad < anmon()) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if ((bre > 7) == true) {
gormru();
} else if (du == true && (bre > 7) != true) {
eckfi();
} else if (in != 0 && (bre > 7) != true && du != true) {
grer();
} else if (wo == true && (bre > 7) != true && du != true && in == 0) {
zonMesgru();
} else if (sian >= 4 && (bre > 7) != true && du != true && in == 0 && wo != true) {
euruis();
}
if (en == true && (bre > 7) != true && du != true && in == 0 && wo != true && sian <= 4) {
pidShihen();
} else if (fi == true && (bre > 7) != true && du != true && in == 0 && wo != true && sian <= 4 && en != true) {
pheas();
} else if ((bre > 7) != true && du != true && in == 0 && wo != true && sian <= 4 && en != true && fi != true) {
pouca();
}
{
if (bre > 7) {
gormru();
}
if (du) {
eckfi();
}
if (in != 0) {
grer();
}
if (wo) {
zonMesgru();
}
if (sian >= 4) {
euruis();
}
if (en) {
pidShihen();
}
if (fi) {
pheas();
}
pouca();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: