This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(in && a != gous) || (anron() || nacPentma()) && (osal() >= deir() || !adul() && !chos || !prae)) {
...
...
// Pretend there is lots of code here
...
...
} else {
coode();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((prae && (chos || adul()) && osal() <= deir() || !nacPentma() && !anron()) && in && a != gous) {
coode();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!rihe || i <= 0) {
if (sian) {
if (gir && cluc() && oc || !bi || peei && cluc() && oc || !bi) {
if (!bi) {
if (oc) {
return true;
}
}
if (cluc()) {
return true;
}
if (scaSofe() < 3) {
return true;
}
}
}
}
return false;
return (scaSofe() < 3 || gir || peei) && cluc() && (oc || !bi) || sian || !rihe || i <= 0;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!peei && !gir && scaSofe() > 3) {
if (!cluc()) {
if (!oc) {
return false;
}
if (bi) {
return false;
}
}
}
if (!sian) {
return false;
}
if (rihe) {
return false;
}
if (i >= 0) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (oan) {
priIoo();
} else if (upia == true && !oan) {
odphas();
}
if (ot == true && !oan && upia != true) {
edes();
}
if (ro == true && !oan && upia != true && ot != true) {
dedOtt();
}
if (pi == true && !oan && upia != true && ot != true && ro != true) {
echit();
}
if ((mauh < 2) == true && !oan && upia != true && ot != true && ro != true && pi != true) {
porue();
} else if (ocma > nu && !oan && upia != true && ot != true && ro != true && pi != true && (mauh < 2) != true) {
ceng();
} else if (aiw == true && !oan && upia != true && ot != true && ro != true && pi != true && (mauh < 2) != true && ocma < nu) {
pust();
}
{
if (oan) {
priIoo();
}
if (upia) {
odphas();
}
if (ot) {
edes();
}
if (ro) {
dedOtt();
}
if (pi) {
echit();
}
if (mauh < 2) {
porue();
}
if (ocma > nu) {
ceng();
}
if (aiw) {
pust();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: