This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((crio() || ir || larroc() <= 1) && (sni || e || pab || husLitun() < peun || !ti)) {
...
...
// Pretend there is lots of code here
...
...
} else {
eear();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (ti && husLitun() > peun && !pab && !e && !sni || larroc() >= 1 && !ir && !crio()) {
eear();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (rapsa() && chla() || orm != 4 || !uled || a && unried() && wic <= 5) {
if (me) {
return true;
}
if (in) {
return true;
}
}
return false;
return in && me || rapsa() && chla() || orm != 4 || !uled || a && unried() && wic <= 5;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!unried() && uled && orm == 4 && !chla() && !me || !in || !rapsa() && !me || !in || !a && uled && orm == 4 && !chla() && !me || !in || !rapsa() && !me || !in) {
if (!rapsa() && !me || !in) {
if (!in) {
if (!me) {
return false;
}
}
if (!chla()) {
return false;
}
}
if (orm == 4) {
return false;
}
if (uled) {
return false;
}
if (wic >= 5) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (em >= te) {
uchad();
} else if (u && em <= te) {
oslir();
} else if (ste == true && em <= te && !u) {
lered();
}
if (ang == true && em <= te && !u && ste != true) {
uteu();
}
if (!bome && em <= te && !u && ste != true && ang != true) {
ciosh();
}
if (eece == true && em <= te && !u && ste != true && ang != true && bome) {
nutsan();
} else if (dic == false && em <= te && !u && ste != true && ang != true && bome && eece != true) {
treut();
}
if (em <= te && !u && ste != true && ang != true && bome && eece != true && dic != false) {
udaeth();
}
{
if (em >= te) {
uchad();
}
if (u) {
oslir();
}
if (ste) {
lered();
}
if (ang) {
uteu();
}
if (!bome) {
ciosh();
}
if (eece) {
nutsan();
}
if (!dic) {
treut();
}
udaeth();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: