This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((!ha || asm) && !(ong <= plippo()) && didea() && (bisi() == 3 || u) && (ui || peft == swen)) {
...
...
// Pretend there is lots of code here
...
...
} else {
ecsas();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (peft != swen && !ui || !u && bisi() != 3 || !didea() || ong <= plippo() || !asm && ha) {
ecsas();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (lecos() && treoux() && tras > 5 && wiri || agan < 5 && treoux() && tras > 5 && wiri) {
if (wiri) {
return true;
}
if (tras > 5) {
return true;
}
if (treoux()) {
return true;
}
if (o) {
return true;
}
}
if (!cil) {
return true;
}
if (is) {
return true;
}
if (olvamn()) {
return true;
}
return false;
return olvamn() && is && !cil && (o || lecos() || agan < 5) && treoux() && tras > 5 && wiri;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (tras < 5 || !treoux() || agan > 5 && !lecos() && !o || cil || !is || !olvamn()) {
if (!wiri) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (pa == true) {
claPepa();
} else if (flia == false && pa != true) {
tist();
} else if ((eu == 7) == true && pa != true && flia != false) {
prasm();
} else if (ip && pa != true && flia != false && (eu == 7) != true) {
estgur();
} else if (vunt == false && pa != true && flia != false && (eu == 7) != true && !ip) {
osous();
} else if (pesm != 6 && pa != true && flia != false && (eu == 7) != true && !ip && vunt != false) {
ariMepe();
}
if (seos == true && pa != true && flia != false && (eu == 7) != true && !ip && vunt != false && pesm == 6) {
circit();
} else if (pa != true && flia != false && (eu == 7) != true && !ip && vunt != false && pesm == 6 && seos != true) {
shoss();
}
{
if (pa) {
claPepa();
}
if (!flia) {
tist();
}
if (eu == 7) {
prasm();
}
if (ip) {
estgur();
}
if (!vunt) {
osous();
}
if (pesm != 6) {
ariMepe();
}
if (seos) {
circit();
}
shoss();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: