This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (((!(sikMameic() >= eddrir()) || salo()) && ordant() || vou <= 2) && omjeph() < ucoPrit() && !rur && mipHec() == 6 && bata == 1) {
...
...
// Pretend there is lots of code here
...
...
} else {
rolla();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (bata != 1 || mipHec() != 6 || rur || omjeph() > ucoPrit() || vou >= 2 && (!ordant() || !salo() && sikMameic() >= eddrir())) {
rolla();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!joac || !atch) {
if (muaca() > 2 && !en && cint) {
if (sliJeco() && cint || ciop() && cint) {
if (cint) {
return true;
}
if (mo == 0) {
return true;
}
}
}
if (vinche() == 4) {
return true;
}
}
return false;
return vinche() == 4 && (mo == 0 || sliJeco() || ciop() || muaca() > 2 && !en) && cint || !joac || !atch;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (en && !ciop() && !sliJeco() && mo != 0 || muaca() < 2 && !ciop() && !sliJeco() && mo != 0 || vinche() != 4) {
if (!cint) {
return false;
}
}
if (joac) {
return false;
}
if (atch) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (a == true) {
sasPrik();
}
if (drud == false && a != true) {
gaisio();
} else if (fiod == ied && a != true && drud != false) {
stoo();
} else if (!pror && a != true && drud != false && fiod != ied) {
girAtri();
} else if (ma == true && a != true && drud != false && fiod != ied && pror) {
spla();
} else if (unt == false && a != true && drud != false && fiod != ied && pror && ma != true) {
bliEgna();
} else if ((he == 9) == true && a != true && drud != false && fiod != ied && pror && ma != true && unt != false) {
naehar();
} else if (a != true && drud != false && fiod != ied && pror && ma != true && unt != false && (he == 9) != true) {
nece();
}
{
if (a) {
sasPrik();
}
if (!drud) {
gaisio();
}
if (fiod == ied) {
stoo();
}
if (!pror) {
girAtri();
}
if (ma) {
spla();
}
if (!unt) {
bliEgna();
}
if (he == 9) {
naehar();
}
nece();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: