This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!uiad && !(pra && satres() <= 5 && hihcan() <= nort && (i || tosm())) && (sadsit() || psac)) {
...
...
// Pretend there is lots of code here
...
...
} else {
bilDosh();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!psac && !sadsit() || pra && satres() <= 5 && hihcan() <= nort && (i || tosm()) || uiad) {
bilDosh();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (fo != buchil() && fu != pe && saac < 1 || !po && nas == 1 || fes && plon == 4 && !ho) {
if (!po && nas == 1 || fes && plon == 4 && !ho) {
if (saac < 1) {
return true;
}
}
if (fu != pe) {
return true;
}
if (ud >= 1) {
return true;
}
}
return false;
return (ud >= 1 || fo != buchil()) && fu != pe && (saac < 1 || !po && (nas == 1 || fes && plon == 4 && !ho));
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (fu == pe || fo == buchil() && ud <= 1) {
if (po && saac > 1) {
if (!fes && nas != 1 && saac > 1) {
if (plon != 4 && nas != 1 && saac > 1) {
if (saac > 1) {
return false;
}
if (nas != 1) {
return false;
}
if (ho) {
return false;
}
}
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (od == true) {
oahis();
} else if (ec == false && od != true) {
zonEseens();
}
if (muc && od != true && ec != false) {
sheho();
}
if (dii < hea && od != true && ec != false && !muc) {
scusm();
} else if ((va == 7) == true && od != true && ec != false && !muc && dii > hea) {
eesmhe();
}
if (ir == true && od != true && ec != false && !muc && dii > hea && (va == 7) != true) {
dedci();
}
if (!ious && od != true && ec != false && !muc && dii > hea && (va == 7) != true && ir != true) {
eisWicple();
}
if (od != true && ec != false && !muc && dii > hea && (va == 7) != true && ir != true && ious) {
gietad();
}
{
if (od) {
oahis();
}
if (!ec) {
zonEseens();
}
if (muc) {
sheho();
}
if (dii < hea) {
scusm();
}
if (va == 7) {
eesmhe();
}
if (ir) {
dedci();
}
if (!ious) {
eisWicple();
}
gietad();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: