This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (whio() || prap || (!(hef != i) || dru == 6 || osved() || issQemben() || leea == 9) && phua >= 5) {
...
...
// Pretend there is lots of code here
...
...
} else {
delme();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((phua <= 5 || leea != 9 && !issQemben() && !osved() && dru != 6 && hef != i) && !prap && !whio()) {
delme();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (o >= 0 && os == 4 && tond && keic() == eal && le || cint || ucox && keic() == eal && le || cint) {
if (palod() && tond && keic() == eal && le || cint || ucox && keic() == eal && le || cint) {
if (ucox && keic() == eal && le || cint) {
if (cint) {
if (le) {
return true;
}
}
if (keic() == eal) {
return true;
}
if (tond) {
return true;
}
}
if (pu) {
return true;
}
}
}
return false;
return (pu || palod() || o >= 0 && os == 4) && (tond || ucox) && keic() == eal && (le || cint);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!ucox && !tond || os != 4 && !palod() && !pu || o <= 0 && !palod() && !pu) {
if (keic() != eal) {
if (!le) {
return false;
}
if (!cint) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (nani == true) {
omePreler();
}
if (eod == true && nani != true) {
prar();
}
if (bi == false && nani != true && eod != true) {
sino();
}
if (!ed && nani != true && eod != true && bi != false) {
cilcic();
} else if (ta == true && nani != true && eod != true && bi != false && ed) {
bossdi();
} else if (sni == false && nani != true && eod != true && bi != false && ed && ta != true) {
giaPhuca();
} else if (jese == true && nani != true && eod != true && bi != false && ed && ta != true && sni != false) {
mokHolin();
} else if (tona == false && nani != true && eod != true && bi != false && ed && ta != true && sni != false && jese != true) {
iongpo();
}
{
if (nani) {
omePreler();
}
if (eod) {
prar();
}
if (!bi) {
sino();
}
if (!ed) {
cilcic();
}
if (ta) {
bossdi();
}
if (!sni) {
giaPhuca();
}
if (jese) {
mokHolin();
}
if (!tona) {
iongpo();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: