This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!ealt() && nass && (!aelTrurt() || !(!enef || a) || (!ulme || ocpoc()) && tre)) {
...
...
// Pretend there is lots of code here
...
...
} else {
celen();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!tre || !ocpoc() && ulme) && (!enef || a) && aelTrurt() || !nass || ealt()) {
celen();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (fal > 2 && eou != 0 || meiWriocu() || tu || birang() && eou != 0 || meiWriocu() || tu) {
if (meiWriocu() || tu) {
if (eou != 0) {
return true;
}
}
if (ven != 1) {
return true;
}
}
if (insnem()) {
return true;
}
if (tir < oscent()) {
return true;
}
if (!me) {
return true;
}
return false;
return !me && tir < oscent() && insnem() && (ven != 1 || fal > 2 || birang()) && (eou != 0 || meiWriocu() || tu);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!insnem() || tir > oscent() || me) {
if (!birang() && fal < 2 && ven == 1) {
if (eou == 0) {
return false;
}
if (!meiWriocu()) {
return false;
}
if (!tu) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (o < ne) {
prasse();
}
if (ia == false && o > ne) {
bioba();
}
if (e != ol && o > ne && ia != false) {
ongOdan();
} else if (maec == true && o > ne && ia != false && e == ol) {
hilAcal();
}
if (om == false && o > ne && ia != false && e == ol && maec != true) {
goatch();
} else if (ina == true && o > ne && ia != false && e == ol && maec != true && om != false) {
ghoi();
}
if ((oon == fe) == true && o > ne && ia != false && e == ol && maec != true && om != false && ina != true) {
neel();
}
if (pel != mic && o > ne && ia != false && e == ol && maec != true && om != false && ina != true && (oon == fe) != true) {
latpsi();
}
{
if (o < ne) {
prasse();
}
if (!ia) {
bioba();
}
if (e != ol) {
ongOdan();
}
if (maec) {
hilAcal();
}
if (!om) {
goatch();
}
if (ina) {
ghoi();
}
if (oon == fe) {
neel();
}
if (pel != mic) {
latpsi();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: