This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((tococ() && ac || brispe() || !dac || gress() == 4 || !du) && coaPtoe() && io) {
...
...
// Pretend there is lots of code here
...
...
} else {
ossjel();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!io || !coaPtoe() || du && gress() != 4 && dac && !brispe() && (!ac || !tococ())) {
ossjel();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (nuss && mooous() && lermhu() == 9 && pri && lenfen() || !clil && lenfen() || on != avbi() && lenfen()) {
if (!obae) {
if (gni) {
return true;
}
}
}
return false;
return gni || !obae || nuss && mooous() && (lermhu() == 9 && pri || !clil || on != avbi()) && lenfen();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!mooous() && obae && !gni || !nuss && obae && !gni) {
if (on == avbi() && clil && !pri && obae && !gni || lermhu() != 9 && obae && !gni) {
if (!gni) {
return false;
}
if (obae) {
return false;
}
if (!lenfen()) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (veir == true) {
whos();
} else if (se == true && veir != true) {
nidbi();
}
if (na < 5 && veir != true && se != true) {
buanth();
}
if (co == true && veir != true && se != true && na > 5) {
claca();
} else if (sqi == true && veir != true && se != true && na > 5 && co != true) {
chocla();
}
if (me == puge && veir != true && se != true && na > 5 && co != true && sqi != true) {
deic();
}
if (lon == true && veir != true && se != true && na > 5 && co != true && sqi != true && me != puge) {
tocas();
}
if (veir != true && se != true && na > 5 && co != true && sqi != true && me != puge && lon != true) {
hipad();
}
{
if (veir) {
whos();
}
if (se) {
nidbi();
}
if (na < 5) {
buanth();
}
if (co) {
claca();
}
if (sqi) {
chocla();
}
if (me == puge) {
deic();
}
if (lon) {
tocas();
}
hipad();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: