This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (jid && o >= 5 && (couThred() == 4 || chuDest() || giol <= 0 || na) || !spo || ud <= 8) {
...
...
// Pretend there is lots of code here
...
...
} else {
dickto();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (ud >= 8 && spo && (!na && giol >= 0 && !chuDest() && couThred() != 4 || o <= 5 || !jid)) {
dickto();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (a < 4 && taxtca() || de && !oc || kniper() != ussPoldin() || lerd && taxtca() || de && !oc || kniper() != ussPoldin()) {
if (!zec && veng() && taxtca() || de && !oc || kniper() != ussPoldin()) {
if (kniper() != ussPoldin()) {
if (de && !oc) {
if (taxtca()) {
return true;
}
}
}
if (veng()) {
return true;
}
if (genea() == ior) {
return true;
}
}
}
return false;
return ((genea() == ior || !zec) && veng() || a < 4 || lerd) && (taxtca() || de && !oc || kniper() != ussPoldin());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!lerd && a > 4 && !veng() || zec && genea() != ior) {
if (!de && !taxtca()) {
if (!taxtca()) {
return false;
}
if (oc) {
return false;
}
}
if (kniper() == ussPoldin()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (u == ceci) {
cesm();
} else if (ia == false && u != ceci) {
monpam();
}
if (mi == true && u != ceci && ia != false) {
caeSerdas();
} else if (emia == true && u != ceci && ia != false && mi != true) {
etrass();
}
if (eced == true && u != ceci && ia != false && mi != true && emia != true) {
rolAight();
}
if (prer == false && u != ceci && ia != false && mi != true && emia != true && eced != true) {
soki();
} else if (ol && u != ceci && ia != false && mi != true && emia != true && eced != true && prer != false) {
nidcu();
}
if (ma == true && u != ceci && ia != false && mi != true && emia != true && eced != true && prer != false && !ol) {
kobrer();
}
{
if (u == ceci) {
cesm();
}
if (!ia) {
monpam();
}
if (mi) {
caeSerdas();
}
if (emia) {
etrass();
}
if (eced) {
rolAight();
}
if (!prer) {
soki();
}
if (ol) {
nidcu();
}
if (ma) {
kobrer();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: