This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!moal && riol && (i && pelEsmclo() && amec == 6 || cror && saol() || !(spoPalduc() == grec()))) {
...
...
// Pretend there is lots of code here
...
...
} else {
alcos();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (spoPalduc() == grec() && (!saol() || !cror) && (amec != 6 || !pelEsmclo() || !i) || !riol || moal) {
alcos();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (imgra() == 5) {
if (!pra && marphi()) {
if (us && !cer && u && !pih) {
if (ou) {
if (kur == 4) {
return true;
}
}
}
}
}
return false;
return kur == 4 || ou || us && !cer && u && !pih || !pra && marphi() || imgra() == 5;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (pra && pih && !ou && kur != 4 || !u && !ou && kur != 4 || cer && !ou && kur != 4 || !us && !ou && kur != 4) {
if (!u && !ou && kur != 4 || cer && !ou && kur != 4 || !us && !ou && kur != 4) {
if (kur != 4) {
return false;
}
if (!ou) {
return false;
}
if (pih) {
return false;
}
}
if (!marphi()) {
return false;
}
}
if (imgra() != 5) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if ((whe == cuc) == true) {
tras();
} else if (er == true && (whe == cuc) != true) {
tect();
}
if (glip == true && (whe == cuc) != true && er != true) {
bonal();
}
if (zom == true && (whe == cuc) != true && er != true && glip != true) {
soin();
}
if (no >= te && (whe == cuc) != true && er != true && glip != true && zom != true) {
stesm();
}
if (el == true && (whe == cuc) != true && er != true && glip != true && zom != true && no <= te) {
ollong();
}
if (se && (whe == cuc) != true && er != true && glip != true && zom != true && no <= te && el != true) {
sacnu();
} else if ((whe == cuc) != true && er != true && glip != true && zom != true && no <= te && el != true && !se) {
prish();
}
{
if (whe == cuc) {
tras();
}
if (er) {
tect();
}
if (glip) {
bonal();
}
if (zom) {
soin();
}
if (no >= te) {
stesm();
}
if (el) {
ollong();
}
if (se) {
sacnu();
}
prish();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: