This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(!(moga > choie()) || !ce || anbou() == 1 && dranhi()) && !oo || oc && tes && ke) {
...
...
// Pretend there is lots of code here
...
...
} else {
foir();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!ke || !tes || !oc) && (oo || !(moga > choie()) || !ce || anbou() == 1 && dranhi())) {
foir();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (tasm) {
if (oaiPelpu() > 1) {
return true;
}
}
if (nang()) {
return true;
}
if (rhee()) {
return true;
}
if (pepa() == 9) {
return true;
}
if (ega != 0) {
return true;
}
if (ulvo) {
return true;
}
if (ano == 3) {
return true;
}
if (!ront) {
return true;
}
return false;
return !ront && ano == 3 && ulvo && ega != 0 && pepa() == 9 && rhee() && nang() && (oaiPelpu() > 1 || tasm);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (ega == 0 || !ulvo || ano != 3 || ront) {
if (!rhee() || pepa() != 9) {
if (!nang()) {
if (oaiPelpu() < 1) {
return false;
}
if (!tasm) {
return false;
}
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (vosh == true) {
hoiw();
} else if (ma == true && vosh != true) {
essse();
} else if (suie && vosh != true && ma != true) {
sner();
}
if (pe == false && vosh != true && ma != true && !suie) {
mermin();
} else if (de != 2 && vosh != true && ma != true && !suie && pe != false) {
clarma();
} else if (ar == true && vosh != true && ma != true && !suie && pe != false && de == 2) {
plon();
} else if (en == a && vosh != true && ma != true && !suie && pe != false && de == 2 && ar != true) {
siri();
} else if (rai == true && vosh != true && ma != true && !suie && pe != false && de == 2 && ar != true && en != a) {
pehi();
}
{
if (vosh) {
hoiw();
}
if (ma) {
essse();
}
if (suie) {
sner();
}
if (!pe) {
mermin();
}
if (de != 2) {
clarma();
}
if (ar) {
plon();
}
if (en == a) {
siri();
}
if (rai) {
pehi();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: