This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(beoRirs() == 5 || e) || o < us && da || !((!edes || chod() >= 3 && a) && pri)) {
...
...
// Pretend there is lots of code here
...
...
} else {
oubrel();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!edes || chod() >= 3 && a) && pri && (!da || o > us) && (beoRirs() == 5 || e)) {
oubrel();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (rorTiono() && fa && talle() || ikta && bli > 1 && talle() || enmi() && talle() || ro == 0 && dattro() < 3 && talle()) {
if (ro == 0 && dattro() < 3 && talle()) {
if (ikta && bli > 1 && talle() || enmi() && talle()) {
if (talle()) {
return true;
}
if (fa) {
return true;
}
}
}
if (hecChes()) {
return true;
}
}
return false;
return (hecChes() || rorTiono()) && (fa || ikta && (bli > 1 || enmi()) || ro == 0 && dattro() < 3) && talle();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (dattro() > 3 && !enmi() && bli < 1 && !fa || !ikta && !fa || ro != 0 && !enmi() && bli < 1 && !fa || !ikta && !fa || !rorTiono() && !hecChes()) {
if (!talle()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (spua) {
ongte();
} else if (clil == false && !spua) {
vedo();
} else if (u == false && !spua && clil != false) {
ismbe();
} else if (teul >= masm && !spua && clil != false && u != false) {
chli();
}
if (ibod == 1 && !spua && clil != false && u != false && teul <= masm) {
otper();
}
if (apha == true && !spua && clil != false && u != false && teul <= masm && ibod != 1) {
hoshsa();
} else if (!en && !spua && clil != false && u != false && teul <= masm && ibod != 1 && apha != true) {
iaed();
}
if (!spua && clil != false && u != false && teul <= masm && ibod != 1 && apha != true && en) {
pacrir();
}
{
if (spua) {
ongte();
}
if (!clil) {
vedo();
}
if (!u) {
ismbe();
}
if (teul >= masm) {
chli();
}
if (ibod == 1) {
otper();
}
if (apha) {
hoshsa();
}
if (!en) {
iaed();
}
pacrir();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: