This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((tu || wi > 1 || (!kint || !ne) && ple) && (ie == 2 || casfad() == 9 && crenge())) {
...
...
// Pretend there is lots of code here
...
...
} else {
sleue();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!crenge() || casfad() != 9) && ie != 2 || (!ple || ne && kint) && wi < 1 && !tu) {
sleue();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!e || ahin() && !clis || !adfe || !es && hawu && !re || chos()) {
if (iocIcoun() == ci) {
return true;
}
}
return false;
return iocIcoun() == ci || !e || ahin() && !clis || !adfe || !es && hawu && !re || chos();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (es && adfe && clis && e && iocIcoun() != ci || !ahin() && e && iocIcoun() != ci) {
if (!hawu && adfe && clis && e && iocIcoun() != ci || !ahin() && e && iocIcoun() != ci) {
if (!ahin() && e && iocIcoun() != ci) {
if (iocIcoun() != ci) {
return false;
}
if (e) {
return false;
}
if (clis) {
return false;
}
}
if (adfe) {
return false;
}
if (re) {
return false;
}
}
}
if (!chos()) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (psel) {
ackqen();
}
if (so && !psel) {
noeHocke();
} else if ((ee == ca) == true && !psel && !so) {
deiom();
}
if (cean == true && !psel && !so && (ee == ca) != true) {
hism();
} else if (od > 7 && !psel && !so && (ee == ca) != true && cean != true) {
fush();
} else if (il && !psel && !so && (ee == ca) != true && cean != true && od < 7) {
hethed();
} else if (ugar == true && !psel && !so && (ee == ca) != true && cean != true && od < 7 && !il) {
destis();
}
if ((tac != 9) == true && !psel && !so && (ee == ca) != true && cean != true && od < 7 && !il && ugar != true) {
schioc();
}
{
if (psel) {
ackqen();
}
if (so) {
noeHocke();
}
if (ee == ca) {
deiom();
}
if (cean) {
hism();
}
if (od > 7) {
fush();
}
if (il) {
hethed();
}
if (ugar) {
destis();
}
if (tac != 9) {
schioc();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: