This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(!(!an && in == pha) || mestri()) && ed >= 8 && !(hudu >= anca) && sepi == 7 && slis && wuuSpah()) {
...
...
// Pretend there is lots of code here
...
...
} else {
uthto();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!wuuSpah() || !slis || sepi != 7 || hudu >= anca || ed <= 8 || !(!an && in == pha) || mestri()) {
uthto();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (efos && ceng() <= 0 && olpus() && pa && si && !so) {
if (!so) {
return true;
}
if (si) {
return true;
}
if (pa) {
return true;
}
if (olpus()) {
return true;
}
if (ceng() <= 0) {
return true;
}
if (!emi) {
return true;
}
if (spiAaid()) {
return true;
}
if (pless()) {
return true;
}
}
return false;
return (pless() && spiAaid() && !emi || efos) && ceng() <= 0 && olpus() && pa && si && !so;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!efos && emi || !spiAaid() || !pless()) {
if (!pa || !olpus() || ceng() >= 0) {
if (!si) {
if (so) {
return false;
}
}
}
}
return true;
Simplify the following messy chain of conditionals:
if ((nict <= ris) == true) {
cicFacoo();
} else if (moes == true && (nict <= ris) != true) {
whel();
} else if (gli == true && (nict <= ris) != true && moes != true) {
rulor();
}
if (on == true && (nict <= ris) != true && moes != true && gli != true) {
cutdet();
}
if (aphe == aok && (nict <= ris) != true && moes != true && gli != true && on != true) {
soucun();
} else if (eidu && (nict <= ris) != true && moes != true && gli != true && on != true && aphe != aok) {
reide();
} else if (peis == vos && (nict <= ris) != true && moes != true && gli != true && on != true && aphe != aok && !eidu) {
cibend();
} else if (a == true && (nict <= ris) != true && moes != true && gli != true && on != true && aphe != aok && !eidu && peis != vos) {
prus();
}
{
if (nict <= ris) {
cicFacoo();
}
if (moes) {
whel();
}
if (gli) {
rulor();
}
if (on) {
cutdet();
}
if (aphe == aok) {
soucun();
}
if (eidu) {
reide();
}
if (peis == vos) {
cibend();
}
if (a) {
prus();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: