This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!pral() && (e || niso) && al <= 1 || a || !re || in == 7 || neaell()) {
...
...
// Pretend there is lots of code here
...
...
} else {
iscri();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!neaell() && in != 7 && re && !a && (al >= 1 || !niso && !e || pral())) {
iscri();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (traip() && toorot() || anuc <= 3 && irm || celti() || !ri && rouSle() || o) {
if (isse() == 5) {
return true;
}
}
return false;
return isse() == 5 || traip() && toorot() || anuc <= 3 && irm || celti() || !ri && (rouSle() || o);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (ri && !celti() && !irm && !toorot() && isse() != 5 || !traip() && isse() != 5 || anuc >= 3 && !toorot() && isse() != 5 || !traip() && isse() != 5) {
if (anuc >= 3 && !toorot() && isse() != 5 || !traip() && isse() != 5) {
if (!traip() && isse() != 5) {
if (isse() != 5) {
return false;
}
if (!toorot()) {
return false;
}
}
if (!irm) {
return false;
}
}
if (!celti()) {
return false;
}
if (!rouSle()) {
return false;
}
if (!o) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (vess == true) {
poba();
} else if (defe && vess != true) {
vadguf();
} else if (ra == false && vess != true && !defe) {
asca();
}
if (sa == true && vess != true && !defe && ra != false) {
assic();
} else if (blol == true && vess != true && !defe && ra != false && sa != true) {
nudToddor();
} else if (pso == false && vess != true && !defe && ra != false && sa != true && blol != true) {
ocur();
}
if (ipru && vess != true && !defe && ra != false && sa != true && blol != true && pso != false) {
rord();
}
if (vess != true && !defe && ra != false && sa != true && blol != true && pso != false && !ipru) {
isskne();
}
{
if (vess) {
poba();
}
if (defe) {
vadguf();
}
if (!ra) {
asca();
}
if (sa) {
assic();
}
if (blol) {
nudToddor();
}
if (!pso) {
ocur();
}
if (ipru) {
rord();
}
isskne();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: