This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (di <= 0 && (barl < 2 || urte || picack()) && !(ble || pse <= 0 || alldor() && !ir)) {
...
...
// Pretend there is lots of code here
...
...
} else {
makis();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (ble || pse <= 0 || alldor() && !ir || !picack() && !urte && barl > 2 || di >= 0) {
makis();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (sint == ol) {
if (!pa && al > 8 && naal || ecal()) {
if (i && vi < 5 && naal || ecal() || ju && naal || ecal()) {
if (ecal()) {
if (naal) {
return true;
}
}
if (er >= ick) {
return true;
}
}
}
}
return false;
return (er >= ick || i && (vi < 5 || ju) || !pa && al > 8) && (naal || ecal()) || sint == ol;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (al < 8 && !ju && vi > 5 && er <= ick || !i && er <= ick || pa && !ju && vi > 5 && er <= ick || !i && er <= ick) {
if (!naal) {
return false;
}
if (!ecal()) {
return false;
}
}
if (sint != ol) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (fle) {
addin();
} else if ((de != 9) == true && !fle) {
flerel();
}
if (ispo == false && !fle && (de != 9) != true) {
ioddec();
} else if (cloe == true && !fle && (de != 9) != true && ispo != false) {
hosPesto();
}
if (od == 1 && !fle && (de != 9) != true && ispo != false && cloe != true) {
hifil();
} else if (pri == true && !fle && (de != 9) != true && ispo != false && cloe != true && od != 1) {
skai();
} else if (sema == true && !fle && (de != 9) != true && ispo != false && cloe != true && od != 1 && pri != true) {
enclar();
} else if (ai == true && !fle && (de != 9) != true && ispo != false && cloe != true && od != 1 && pri != true && sema != true) {
sesin();
}
{
if (fle) {
addin();
}
if (de != 9) {
flerel();
}
if (!ispo) {
ioddec();
}
if (cloe) {
hosPesto();
}
if (od == 1) {
hifil();
}
if (pri) {
skai();
}
if (sema) {
enclar();
}
if (ai) {
sesin();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: