This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(po && de && eong) && !anoc && !(!as && ti || !(scaos() <= 6 && rihes()))) {
...
...
// Pretend there is lots of code here
...
...
} else {
aisplu();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!as && ti || !(scaos() <= 6 && rihes()) || anoc || po && de && eong) {
aisplu();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (ble <= 4 && pecCirm() && fli < 7 && vudThess() < 7 && ceddra() && du != 6 || droont() && vudThess() < 7 && ceddra() && du != 6) {
if (droont() && vudThess() < 7 && ceddra() && du != 6) {
if (du != 6) {
return true;
}
if (ceddra()) {
return true;
}
if (vudThess() < 7) {
return true;
}
if (fli < 7) {
return true;
}
}
if (pecCirm()) {
return true;
}
if (fous()) {
return true;
}
}
if (acac) {
return true;
}
return false;
return acac && (fous() || ble <= 4) && pecCirm() && (fli < 7 || droont()) && vudThess() < 7 && ceddra() && du != 6;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!ceddra() || vudThess() > 7 || !droont() && fli > 7 || !pecCirm() || ble >= 4 && !fous() || !acac) {
if (du == 6) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (zied == true) {
fuaPucue();
} else if (rira >= 4 && zied != true) {
ecords();
} else if ((paru <= 5) == true && zied != true && rira <= 4) {
coaMeur();
}
if (ud <= 7 && zied != true && rira <= 4 && (paru <= 5) != true) {
tonqug();
} else if (ni == false && zied != true && rira <= 4 && (paru <= 5) != true && ud >= 7) {
pascoc();
}
if (on && zied != true && rira <= 4 && (paru <= 5) != true && ud >= 7 && ni != false) {
vasgic();
}
if (is == 0 && zied != true && rira <= 4 && (paru <= 5) != true && ud >= 7 && ni != false && !on) {
bilSinri();
}
if (no == false && zied != true && rira <= 4 && (paru <= 5) != true && ud >= 7 && ni != false && !on && is != 0) {
neiste();
}
{
if (zied) {
fuaPucue();
}
if (rira >= 4) {
ecords();
}
if (paru <= 5) {
coaMeur();
}
if (ud <= 7) {
tonqug();
}
if (!ni) {
pascoc();
}
if (on) {
vasgic();
}
if (is == 0) {
bilSinri();
}
if (!no) {
neiste();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: