This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!((!rhi || stedio() || odple() <= 9) && sifeus() && as && cexmio() < 1) || eaen < 4 || ishel()) {
...
...
// Pretend there is lots of code here
...
...
} else {
buston();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!ishel() && eaen > 4 && (!rhi || stedio() || odple() <= 9) && sifeus() && as && cexmio() < 1) {
buston();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (da && scera() > 4 && a || !ziba && a) {
if (wraAnmi() || fleng() || brer() == 0) {
if (wiosa() <= 1) {
return true;
}
if (greng()) {
return true;
}
}
}
return false;
return greng() && wiosa() <= 1 || wraAnmi() || fleng() || brer() == 0 || da && (scera() > 4 || !ziba) && a;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!da && brer() != 0 && !fleng() && !wraAnmi() && wiosa() >= 1 || !greng()) {
if (ziba && scera() < 4 && brer() != 0 && !fleng() && !wraAnmi() && wiosa() >= 1 || !greng()) {
if (!greng()) {
if (wiosa() >= 1) {
return false;
}
}
if (!wraAnmi()) {
return false;
}
if (!fleng()) {
return false;
}
if (brer() != 0) {
return false;
}
if (!a) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (vos == 7) {
bilLoul();
}
if (ipe == false && vos != 7) {
cria();
} else if (eba == false && vos != 7 && ipe != false) {
bemo();
}
if (so == true && vos != 7 && ipe != false && eba != false) {
ginpe();
} else if (ha != 6 && vos != 7 && ipe != false && eba != false && so != true) {
nesfa();
}
if (smen > eur && vos != 7 && ipe != false && eba != false && so != true && ha == 6) {
ialka();
} else if (i == false && vos != 7 && ipe != false && eba != false && so != true && ha == 6 && smen < eur) {
eckspi();
} else if (vos != 7 && ipe != false && eba != false && so != true && ha == 6 && smen < eur && i != false) {
eparm();
}
{
if (vos == 7) {
bilLoul();
}
if (!ipe) {
cria();
}
if (!eba) {
bemo();
}
if (so) {
ginpe();
}
if (ha != 6) {
nesfa();
}
if (smen > eur) {
ialka();
}
if (!i) {
eckspi();
}
eparm();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: