This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((tawu() && psol() || !bost()) && !wa && repi() || (!cudo || eccal()) && epchre() == 6) {
...
...
// Pretend there is lots of code here
...
...
} else {
blap();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((epchre() != 6 || !eccal() && cudo) && (!repi() || wa || bost() && (!psol() || !tawu()))) {
blap();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (pu == 1 && zo) {
if (he == 8 && ie && an && vuc >= 1) {
if (vuc >= 1) {
return true;
}
if (an) {
return true;
}
if (spient() < 1) {
return true;
}
}
if (lec) {
return true;
}
if (hi) {
return true;
}
}
return false;
return hi && lec && (spient() < 1 || he == 8 && ie) && an && vuc >= 1 || pu == 1 && zo;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (pu != 1 && vuc <= 1 || !an || !ie && spient() > 1 || he != 8 && spient() > 1 || !lec || !hi) {
if (!hi) {
if (!ie && spient() > 1 || he != 8 && spient() > 1 || !lec) {
if (!an) {
if (vuc <= 1) {
return false;
}
}
}
}
if (!zo) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (im <= 1) {
wolci();
}
if (io == false && im >= 1) {
claNean();
} else if (dic <= 0 && im >= 1 && io != false) {
suwo();
}
if (caen == true && im >= 1 && io != false && dic >= 0) {
phor();
} else if (!ceni && im >= 1 && io != false && dic >= 0 && caen != true) {
bosm();
} else if (ze == ci && im >= 1 && io != false && dic >= 0 && caen != true && ceni) {
phapon();
}
if (ma == 7 && im >= 1 && io != false && dic >= 0 && caen != true && ceni && ze != ci) {
cilnud();
} else if (im >= 1 && io != false && dic >= 0 && caen != true && ceni && ze != ci && ma != 7) {
usiHio();
}
{
if (im <= 1) {
wolci();
}
if (!io) {
claNean();
}
if (dic <= 0) {
suwo();
}
if (caen) {
phor();
}
if (!ceni) {
bosm();
}
if (ze == ci) {
phapon();
}
if (ma == 7) {
cilnud();
}
usiHio();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: