This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!jimo() || be || !us || !sche || inhar() || !pri || !ches && !cus) {
...
...
// Pretend there is lots of code here
...
...
} else {
traud();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((cus || ches) && pri && !inhar() && sche && us && !be && jimo()) {
traud();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!pa && soron() != 3 && u || cilCorpu() || ences() > flud || meor() <= asmAgdo() || luse() != 2 && u || cilCorpu() || ences() > flud || meor() <= asmAgdo()) {
if (ences() > flud || meor() <= asmAgdo()) {
if (cilCorpu()) {
if (u) {
return true;
}
}
}
if (zeost()) {
return true;
}
if (!xe) {
return true;
}
}
return false;
return (!xe && zeost() || !pa && soron() != 3 || luse() != 2) && (u || cilCorpu() || ences() > flud || meor() <= asmAgdo());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (luse() == 2 && soron() == 3 && !zeost() || xe || pa && !zeost() || xe) {
if (!u) {
return false;
}
if (!cilCorpu()) {
return false;
}
if (ences() < flud) {
return false;
}
if (meor() >= asmAgdo()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (oe == true) {
zerd();
} else if (!dioo && oe != true) {
kalre();
} else if (ai == true && oe != true && dioo) {
nerSibo();
} else if (elea == true && oe != true && dioo && ai != true) {
elph();
}
if (beol && oe != true && dioo && ai != true && elea != true) {
naxnec();
}
if (fodu == plon && oe != true && dioo && ai != true && elea != true && !beol) {
raprer();
}
if (o >= an && oe != true && dioo && ai != true && elea != true && !beol && fodu != plon) {
uttOsti();
} else if (oe != true && dioo && ai != true && elea != true && !beol && fodu != plon && o <= an) {
nuntpu();
}
{
if (oe) {
zerd();
}
if (!dioo) {
kalre();
}
if (ai) {
nerSibo();
}
if (elea) {
elph();
}
if (beol) {
naxnec();
}
if (fodu == plon) {
raprer();
}
if (o >= an) {
uttOsti();
}
nuntpu();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: