This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!ruam && (dirlci() || crui() != 1 && wict() && !ce) && !(hil && e && !(husde() == 3))) {
...
...
// Pretend there is lots of code here
...
...
} else {
rhia();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (hil && e && !(husde() == 3) || (ce || !wict() || crui() == 1) && !dirlci() || ruam) {
rhia();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (tioc() == 6 && ruc && sul && di != cagi() || se < 4 && di != cagi() || !ao) {
if (!ao) {
if (se < 4 && di != cagi()) {
if (di != cagi()) {
return true;
}
if (sul) {
return true;
}
}
if (ruc) {
return true;
}
}
if (i) {
return true;
}
}
if (plee) {
return true;
}
if (pi < 6) {
return true;
}
return false;
return pi < 6 && plee && (i || tioc() == 6) && (ruc && (sul || se < 4) && di != cagi() || !ao);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (tioc() != 6 && !i || !plee || pi > 6) {
if (se > 4 && !sul || !ruc) {
if (di == cagi()) {
return false;
}
}
if (ao) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (oc >= 8) {
nesar();
} else if (en == true && oc <= 8) {
fafSwir();
} else if (ol == true && oc <= 8 && en != true) {
luan();
}
if (so == true && oc <= 8 && en != true && ol != true) {
clol();
} else if (!tiss && oc <= 8 && en != true && ol != true && so != true) {
achat();
}
if (ba == false && oc <= 8 && en != true && ol != true && so != true && tiss) {
zicid();
} else if (po == true && oc <= 8 && en != true && ol != true && so != true && tiss && ba != false) {
tord();
} else if (oc <= 8 && en != true && ol != true && so != true && tiss && ba != false && po != true) {
dasco();
}
{
if (oc >= 8) {
nesar();
}
if (en) {
fafSwir();
}
if (ol) {
luan();
}
if (so) {
clol();
}
if (!tiss) {
achat();
}
if (!ba) {
zicid();
}
if (po) {
tord();
}
dasco();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: