This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (mecu == 4 && !gavi && al && ostdu() || a || !(celNenla() == 6 || netche() < 8 || pren == 9)) {
...
...
// Pretend there is lots of code here
...
...
} else {
tist();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((celNenla() == 6 || netche() < 8 || pren == 9) && !a && (!ostdu() || !al || gavi || mecu != 4)) {
tist();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (ud != 0 || ol) {
if (oss && skom && !doi && phix || hasoo() && !doi && phix || ce && phix) {
if (ce && phix) {
if (hasoo() && !doi && phix) {
if (phix) {
return true;
}
if (!doi) {
return true;
}
if (skom) {
return true;
}
}
}
if (socon()) {
return true;
}
}
}
return false;
return (socon() || oss) && ((skom || hasoo()) && !doi || ce) && phix || ud != 0 || ol;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!ce && doi || !hasoo() && !skom || !oss && !socon()) {
if (!phix) {
return false;
}
}
if (ud == 0) {
return false;
}
if (!ol) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (se == true) {
stist();
} else if (id >= il == true && se != true) {
asme();
}
if (ho > 7 && se != true && id >= il != true) {
budeir();
}
if (om == true && se != true && id >= il != true && ho < 7) {
haho();
} else if (pae && se != true && id >= il != true && ho < 7 && om != true) {
ilcan();
} else if (aght == false && se != true && id >= il != true && ho < 7 && om != true && !pae) {
nelHeid();
} else if (acve == false && se != true && id >= il != true && ho < 7 && om != true && !pae && aght != false) {
breac();
} else if (se != true && id >= il != true && ho < 7 && om != true && !pae && aght != false && acve != false) {
rerCuci();
}
{
if (se) {
stist();
}
if (id >= il) {
asme();
}
if (ho > 7) {
budeir();
}
if (om) {
haho();
}
if (pae) {
ilcan();
}
if (!aght) {
nelHeid();
}
if (!acve) {
breac();
}
rerCuci();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: