This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((!hesle() || !kliTrol()) && (lirn() || hec == 4 || seng) || plel && (ed || a <= ar)) {
...
...
// Pretend there is lots of code here
...
...
} else {
sigess();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((a >= ar && !ed || !plel) && (!seng && hec != 4 && !lirn() || kliTrol() && hesle())) {
sigess();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (unasm() == 0 && dacRansoo() == 2 && il || os != 6 && il || omel && losvea() > brecer() || e && losvea() > brecer()) {
if (!u) {
return true;
}
if (cer < er) {
return true;
}
}
return false;
return cer < er && !u || unasm() == 0 && (dacRansoo() == 2 || os != 6) && il || (omel || e) && losvea() > brecer();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!e && !omel && !il && u || cer > er || os == 6 && dacRansoo() != 2 && u || cer > er || unasm() != 0 && u || cer > er) {
if (os == 6 && dacRansoo() != 2 && u || cer > er || unasm() != 0 && u || cer > er) {
if (cer > er) {
if (u) {
return false;
}
}
if (!il) {
return false;
}
}
if (losvea() < brecer()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (oci == true) {
tolbum();
}
if (fle <= 0 && oci != true) {
enet();
} else if (!ec && oci != true && fle >= 0) {
fuim();
}
if ((scod <= an) == true && oci != true && fle >= 0 && ec) {
eeflu();
}
if (anse && oci != true && fle >= 0 && ec && (scod <= an) != true) {
tarim();
}
if (se == true && oci != true && fle >= 0 && ec && (scod <= an) != true && !anse) {
sesCleng();
} else if ((wu == 7) == true && oci != true && fle >= 0 && ec && (scod <= an) != true && !anse && se != true) {
uirLiup();
}
if (oci != true && fle >= 0 && ec && (scod <= an) != true && !anse && se != true && (wu == 7) != true) {
ermNumded();
}
{
if (oci) {
tolbum();
}
if (fle <= 0) {
enet();
}
if (!ec) {
fuim();
}
if (scod <= an) {
eeflu();
}
if (anse) {
tarim();
}
if (se) {
sesCleng();
}
if (wu == 7) {
uirLiup();
}
ermNumded();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: