This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!es && qe == 9 && ce || ermpac() && proe == 6 || stinil() && (veoir() >= chos || issui())) {
...
...
// Pretend there is lots of code here
...
...
} else {
migh();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!issui() && veoir() <= chos || !stinil()) && (proe != 6 || !ermpac()) && (!ce || qe != 9 || es)) {
migh();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (eck && onk <= 1 || sutre()) {
if (e == gaisci() && onk <= 1 || sutre() || vot && onk <= 1 || sutre()) {
if (bi && onk <= 1 || sutre() || !ha && onk <= 1 || sutre() || le >= 4 && onk <= 1 || sutre()) {
if (sutre()) {
if (onk <= 1) {
return true;
}
}
if (!mosm) {
return true;
}
}
}
}
return false;
return (!mosm || bi || !ha || le >= 4 || e == gaisci() || vot || eck) && (onk <= 1 || sutre());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!eck && !vot && e != gaisci() && le <= 4 && ha && !bi && mosm) {
if (onk >= 1) {
return false;
}
if (!sutre()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (si == true) {
temi();
}
if (sont == true && si != true) {
minch();
}
if (tiha == true && si != true && sont != true) {
prijus();
} else if (enac == true && si != true && sont != true && tiha != true) {
hamle();
}
if (unt == true && si != true && sont != true && tiha != true && enac != true) {
proaeo();
} else if (eid == false && si != true && sont != true && tiha != true && enac != true && unt != true) {
bilButec();
} else if (ic != rhil && si != true && sont != true && tiha != true && enac != true && unt != true && eid != false) {
blount();
}
if (si != true && sont != true && tiha != true && enac != true && unt != true && eid != false && ic == rhil) {
pemook();
}
{
if (si) {
temi();
}
if (sont) {
minch();
}
if (tiha) {
prijus();
}
if (enac) {
hamle();
}
if (unt) {
proaeo();
}
if (!eid) {
bilButec();
}
if (ic != rhil) {
blount();
}
pemook();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: