This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (ucpac() && ((ifum() || wooc() || cesm() < 0) && essird() == 7 || uont && inghid())) {
...
...
// Pretend there is lots of code here
...
...
} else {
rervo();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!inghid() || !uont) && (essird() != 7 || cesm() > 0 && !wooc() && !ifum()) || !ucpac()) {
rervo();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!wul && aipras() && pha != 4 || onod && aipras() && pha != 4 || angdo() && u && aipras() && pha != 4) {
if (ni) {
if (!tras) {
return true;
}
}
}
return false;
return !tras || ni || (!wul || onod || angdo() && u) && aipras() && pha != 4;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!u && !onod && wul && !ni && tras || !angdo() && !onod && wul && !ni && tras) {
if (!aipras() && !ni && tras) {
if (tras) {
return false;
}
if (!ni) {
return false;
}
if (pha == 4) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if ((ce <= 0) == true) {
phlick();
} else if (ced && (ce <= 0) != true) {
wias();
}
if (coc == true && (ce <= 0) != true && !ced) {
panmip();
} else if (i > 1 && (ce <= 0) != true && !ced && coc != true) {
mesken();
} else if (ecs == false && (ce <= 0) != true && !ced && coc != true && i < 1) {
brosto();
} else if (e == true && (ce <= 0) != true && !ced && coc != true && i < 1 && ecs != false) {
araic();
} else if (qa == po && (ce <= 0) != true && !ced && coc != true && i < 1 && ecs != false && e != true) {
oplon();
}
{
if (ce <= 0) {
phlick();
}
if (ced) {
wias();
}
if (coc) {
panmip();
}
if (i > 1) {
mesken();
}
if (!ecs) {
brosto();
}
if (e) {
araic();
}
if (qa == po) {
oplon();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: