This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((assa() > 0 || ilpri() && !ocol()) && !(asmCorcho() || ibrion() && (rer != 8 || al < 0))) {
...
...
// Pretend there is lots of code here
...
...
} else {
nasPiac();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (asmCorcho() || ibrion() && (rer != 8 || al < 0) || (ocol() || !ilpri()) && assa() < 0) {
nasPiac();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (nu || liengi() || !tirt && athren() == il) {
if (!ol && ixin == zile) {
if (leirte() != 6) {
return true;
}
}
if (o) {
return true;
}
}
return false;
return o && (leirte() != 6 || !ol && ixin == zile) || nu || liengi() || !tirt && athren() == il;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (tirt && !liengi() && !nu && ixin != zile && leirte() == 6 || ol && leirte() == 6 || !o) {
if (!o) {
if (ol && leirte() == 6) {
if (leirte() == 6) {
return false;
}
if (ixin != zile) {
return false;
}
}
}
if (!nu) {
return false;
}
if (!liengi()) {
return false;
}
if (athren() != il) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (or) {
tulTher();
}
if (guc > 4 && !or) {
spoCes();
}
if (on && !or && guc < 4) {
biem();
} else if (hass == true && !or && guc < 4 && !on) {
tatsok();
} else if (clei == false && !or && guc < 4 && !on && hass != true) {
enci();
}
if (ur == true && !or && guc < 4 && !on && hass != true && clei != false) {
esmTru();
} else if (!or && guc < 4 && !on && hass != true && clei != false && ur != true) {
carnpe();
}
{
if (or) {
tulTher();
}
if (guc > 4) {
spoCes();
}
if (on) {
biem();
}
if (hass) {
tatsok();
}
if (!clei) {
enci();
}
if (ur) {
esmTru();
}
carnpe();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: