This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!ma && ces > bie || vardi() == ste || (e || !tuic) && niss() || spus >= 8) {
...
...
// Pretend there is lots of code here
...
...
} else {
aescis();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (spus <= 8 && (!niss() || tuic && !e) && vardi() != ste && (ces < bie || ma)) {
aescis();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (tren() >= 5 && ossgro() && !qoea && es == 9 || sism()) {
if (!poc || ta == dism) {
if (cel) {
return true;
}
}
}
return false;
return cel || !poc || ta == dism || tren() >= 5 && ossgro() && !qoea && (es == 9 || sism());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (qoea && ta != dism && poc && !cel || !ossgro() && ta != dism && poc && !cel || tren() <= 5 && ta != dism && poc && !cel) {
if (!cel) {
return false;
}
if (poc) {
return false;
}
if (ta != dism) {
return false;
}
if (es != 9) {
return false;
}
if (!sism()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (soje == true) {
pecur();
} else if (se == true && soje != true) {
edfif();
}
if (ve && soje != true && se != true) {
fluil();
} else if (ciro == true && soje != true && se != true && !ve) {
wrea();
} else if ((si <= 3) == true && soje != true && se != true && !ve && ciro != true) {
iuhal();
}
if (gifu && soje != true && se != true && !ve && ciro != true && (si <= 3) != true) {
qeng();
}
if (soje != true && se != true && !ve && ciro != true && (si <= 3) != true && !gifu) {
phlent();
}
{
if (soje) {
pecur();
}
if (se) {
edfif();
}
if (ve) {
fluil();
}
if (ciro) {
wrea();
}
if (si <= 3) {
iuhal();
}
if (gifu) {
qeng();
}
phlent();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: