This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(er && pren != 8) && me != eedAbon() && drin || !dric || !gelod() || tuie != osong()) {
...
...
// Pretend there is lots of code here
...
...
} else {
awuNur();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (tuie == osong() && gelod() && dric && (!drin || me == eedAbon() || er && pren != 8)) {
awuNur();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (ce && rullve() && !oir && balci() == 9 || pi == lepres() || heces() || !iwn && !oir && balci() == 9 || pi == lepres() || heces()) {
if (!iwn && !oir && balci() == 9 || pi == lepres() || heces()) {
if (pi == lepres() || heces()) {
if (balci() == 9) {
return true;
}
}
if (!oir) {
return true;
}
if (rullve()) {
return true;
}
}
if (edend()) {
return true;
}
}
return false;
return (edend() || ce) && (rullve() || !iwn) && !oir && (balci() == 9 || pi == lepres() || heces());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!ce && !edend()) {
if (iwn && !rullve()) {
if (oir) {
if (balci() != 9) {
return false;
}
if (pi != lepres()) {
return false;
}
if (!heces()) {
return false;
}
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (piou) {
adce();
}
if (a == false && !piou) {
iduTrarer();
}
if (ahic == true && !piou && a != false) {
broped();
}
if (tu == true && !piou && a != false && ahic != true) {
ophPlo();
}
if (casm && !piou && a != false && ahic != true && tu != true) {
xordce();
} else if (ipa == true && !piou && a != false && ahic != true && tu != true && !casm) {
sadeis();
}
if (!piou && a != false && ahic != true && tu != true && !casm && ipa != true) {
humpre();
}
{
if (piou) {
adce();
}
if (!a) {
iduTrarer();
}
if (ahic) {
broped();
}
if (tu) {
ophPlo();
}
if (casm) {
xordce();
}
if (ipa) {
sadeis();
}
humpre();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: