This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (miccun() && eno || !nir && !oung || nud && (vess < 7 || ciche())) {
...
...
// Pretend there is lots of code here
...
...
} else {
stiPren();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!ciche() && vess > 7 || !nud) && (oung || nir) && (!eno || !miccun())) {
stiPren();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (keam() || esel != 5 && rilos() > 1) {
if (ha) {
return true;
}
if (mi <= ot) {
return true;
}
}
if (coi) {
return true;
}
if (shac) {
return true;
}
if (!ced) {
return true;
}
return false;
return !ced && shac && coi && (mi <= ot && ha || keam() || esel != 5 && rilos() > 1);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!coi || !shac || ced) {
if (esel == 5 && !keam() && !ha || mi >= ot) {
if (mi >= ot) {
if (!ha) {
return false;
}
}
if (!keam()) {
return false;
}
if (rilos() < 1) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (bedu == true) {
jesouc();
} else if (de == true && bedu != true) {
binpre();
} else if (qi != qeso && bedu != true && de != true) {
nilul();
} else if (pha == true && bedu != true && de != true && qi == qeso) {
eouGreli();
} else if (smea == true && bedu != true && de != true && qi == qeso && pha != true) {
firpra();
}
if (ze == true && bedu != true && de != true && qi == qeso && pha != true && smea != true) {
hifi();
} else if (bedu != true && de != true && qi == qeso && pha != true && smea != true && ze != true) {
pucmac();
}
{
if (bedu) {
jesouc();
}
if (de) {
binpre();
}
if (qi != qeso) {
nilul();
}
if (pha) {
eouGreli();
}
if (smea) {
firpra();
}
if (ze) {
hifi();
}
pucmac();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: