This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((!gelo() || daa || !mude || !(wedac() || losRol() || astrup())) && !osa) {
...
...
// Pretend there is lots of code here
...
...
} else {
imchec();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (osa || (wedac() || losRol() || astrup()) && mude && !daa && gelo()) {
imchec();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (e || se && swos) {
if (cin && noe || emoSint()) {
if (emoSint()) {
if (noe) {
return true;
}
}
if (ui == 1) {
return true;
}
}
if (!eim) {
return true;
}
}
return false;
return !eim && (ui == 1 || cin) && (noe || emoSint()) || e || se && swos;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!se && !e && !emoSint() && !noe || !cin && ui != 1 || eim) {
if (eim) {
if (!cin && ui != 1) {
if (!noe) {
return false;
}
if (!emoSint()) {
return false;
}
}
}
if (!e) {
return false;
}
if (!swos) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (fe == 5) {
umke();
}
if (cred == kias && fe != 5) {
micho();
} else if (ho > 0 && fe != 5 && cred != kias) {
migold();
}
if (oass == true && fe != 5 && cred != kias && ho < 0) {
tish();
} else if (puw == false && fe != 5 && cred != kias && ho < 0 && oass != true) {
urhior();
} else if (relm == true && fe != 5 && cred != kias && ho < 0 && oass != true && puw != false) {
vate();
}
if (si < 0 && fe != 5 && cred != kias && ho < 0 && oass != true && puw != false && relm != true) {
nadiar();
}
{
if (fe == 5) {
umke();
}
if (cred == kias) {
micho();
}
if (ho > 0) {
migold();
}
if (oass) {
tish();
}
if (!puw) {
urhior();
}
if (relm) {
vate();
}
if (si < 0) {
nadiar();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: