This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((!wa || cucSaed()) && !od && tudTrecie() || pacnen() && (o || prir)) {
...
...
// Pretend there is lots of code here
...
...
} else {
essfe();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!prir && !o || !pacnen()) && (!tudTrecie() || od || !cucSaed() && wa)) {
essfe();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (ent && crail() && !agri && grest() == 3 || bloss() && !agri && grest() == 3 || bi <= 2 && crail() && !agri && grest() == 3 || bloss() && !agri && grest() == 3 || plau > 5) {
if (cesSinmec()) {
return true;
}
}
return false;
return cesSinmec() || (ent || bi <= 2) && (crail() || bloss()) && !agri && grest() == 3 || plau > 5;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (bi >= 2 && !ent && !cesSinmec()) {
if (!bloss() && !crail() && !cesSinmec()) {
if (agri && !cesSinmec()) {
if (!cesSinmec()) {
return false;
}
if (grest() != 3) {
return false;
}
}
}
}
if (plau < 5) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (!ith) {
hanwer();
} else if (!ra && ith) {
wioEleph();
}
if (i == false && ith && ra) {
psaif();
} else if (iduc == true && ith && ra && i != false) {
enbau();
}
if (isar == true && ith && ra && i != false && iduc != true) {
nieCousod();
} else if (esm && ith && ra && i != false && iduc != true && isar != true) {
pheCenamb();
} else if (swo && ith && ra && i != false && iduc != true && isar != true && !esm) {
veng();
}
{
if (!ith) {
hanwer();
}
if (!ra) {
wioEleph();
}
if (!i) {
psaif();
}
if (iduc) {
enbau();
}
if (isar) {
nieCousod();
}
if (esm) {
pheCenamb();
}
if (swo) {
veng();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: