This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(uc || !(nas && ri)) && (wealsi() || !rean) && !gepan() && gancud()) {
...
...
// Pretend there is lots of code here
...
...
} else {
ilew();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!gancud() || gepan() || rean && !wealsi() || uc || !(nas && ri)) {
ilew();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (tiplu() && giu || a || edic || passbi()) {
if (toapa()) {
if (lurcho() != niord()) {
return true;
}
}
if (teni) {
return true;
}
}
return false;
return teni && (lurcho() != niord() || toapa()) || tiplu() && giu || a || edic || passbi();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!tiplu() && !toapa() && lurcho() == niord() || !teni) {
if (!teni) {
if (lurcho() == niord()) {
return false;
}
if (!toapa()) {
return false;
}
}
if (!giu) {
return false;
}
}
if (!a) {
return false;
}
if (!edic) {
return false;
}
if (!passbi()) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (ue == false) {
cral();
}
if (cla == true && ue != false) {
bersec();
}
if (thi == true && ue != false && cla != true) {
eangce();
}
if (qire == true && ue != false && cla != true && thi != true) {
aaer();
}
if (i == true && ue != false && cla != true && thi != true && qire != true) {
somoss();
} else if (qel == true && ue != false && cla != true && thi != true && qire != true && i != true) {
oort();
}
if (ue != false && cla != true && thi != true && qire != true && i != true && qel != true) {
dersic();
}
{
if (!ue) {
cral();
}
if (cla) {
bersec();
}
if (thi) {
eangce();
}
if (qire) {
aaer();
}
if (i) {
somoss();
}
if (qel) {
oort();
}
dersic();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: