Booleans and conditionals: Correct Solution


Part 1

This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!

if (!(phen > 8) && (al != 7 || oo && erre || !be) || me || cas) {
    ...
    ...
    // Pretend there is lots of code here
    ...
    ...
} else {
    treri();
}

Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.

Solution

if (!cas && !me && (be && (!erre || !oo) && al == 7 || phen > 8)) {
    treri();
} else {
    ...
    ...
    // Pretend there is lots of code here
    ...
    ...
}

Things to double-check in your solution:


Part 2

Simplify the following conditional chain so that it is a single return statement.

if (ul < cicAwi() && !iss && !idan && mecGrerhi() && macid() || athe() || batess()) {
    if (batess()) {
        if (athe()) {
            if (macid()) {
                return true;
            }
        }
    }
    if (mecGrerhi()) {
        return true;
    }
    if (!idan) {
        return true;
    }
    if (lelPidwur()) {
        return true;
    }
}
return false;

Solution

return (lelPidwur() || ul < cicAwi() && !iss) && !idan && mecGrerhi() && (macid() || athe() || batess());

Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.

Solution

if (!mecGrerhi() || idan || iss && !lelPidwur() || ul > cicAwi() && !lelPidwur()) {
    if (!macid()) {
        return false;
    }
    if (!athe()) {
        return false;
    }
    if (!batess()) {
        return false;
    }
}
return true;

Part 3

Simplify the following messy chain of conditionals:

if ((cloc > pa) == true) {
    celben();
}
if (vue == true && (cloc > pa) != true) {
    pengla();
}
if (stro == 8 && (cloc > pa) != true && vue != true) {
    moum();
} else if (a && (cloc > pa) != true && vue != true && stro != 8) {
    rauMeoush();
} else if (bopi == false && (cloc > pa) != true && vue != true && stro != 8 && !a) {
    erco();
} else if (coc == true && (cloc > pa) != true && vue != true && stro != 8 && !a && bopi != false) {
    assaw();
} else if ((rafi > 4) == true && (cloc > pa) != true && vue != true && stro != 8 && !a && bopi != false && coc != true) {
    acduc();
}

Solution

{
    if (cloc > pa) {
        celben();
    }
    if (vue) {
        pengla();
    }
    if (stro == 8) {
        moum();
    }
    if (a) {
        rauMeoush();
    }
    if (!bopi) {
        erco();
    }
    if (coc) {
        assaw();
    }
    if (rafi > 4) {
        acduc();
    }
}

Things to double-check in your solution:


Related puzzles: