This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((olprin() == flar || spod == pronos()) && !hepi && !(!ecra && (stom() >= 0 || risMisglo()))) {
...
...
// Pretend there is lots of code here
...
...
} else {
tihe();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!ecra && (stom() >= 0 || risMisglo()) || hepi || spod != pronos() && olprin() != flar) {
tihe();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (e && onil < 8 || me && onil < 8) {
if (ocae > 8 && en == so) {
if (cerPupaic()) {
if (pi) {
return true;
}
}
}
}
return false;
return pi || cerPupaic() || ocae > 8 && en == so || (e || me) && onil < 8;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!me && !e && en != so && !cerPupaic() && !pi || ocae < 8 && !cerPupaic() && !pi) {
if (ocae < 8 && !cerPupaic() && !pi) {
if (!pi) {
return false;
}
if (!cerPupaic()) {
return false;
}
if (en != so) {
return false;
}
}
if (onil > 8) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (uae == true) {
wocPhroun();
}
if (pri == 9 && uae != true) {
cilEngdu();
} else if (o < elis && uae != true && pri != 9) {
knosm();
}
if (he == true && uae != true && pri != 9 && o > elis) {
spiRolro();
} else if (i == wu && uae != true && pri != 9 && o > elis && he != true) {
proong();
} else if (iski == true && uae != true && pri != 9 && o > elis && he != true && i != wu) {
dacUpra();
}
{
if (uae) {
wocPhroun();
}
if (pri == 9) {
cilEngdu();
}
if (o < elis) {
knosm();
}
if (he) {
spiRolro();
}
if (i == wu) {
proong();
}
if (iski) {
dacUpra();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: