This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (pheo && adea || !(pi <= 9) || stiaei() && a || hil < 3) {
...
...
// Pretend there is lots of code here
...
...
} else {
eurt();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (hil > 3 && (!a || !stiaei()) && pi <= 9 && (!adea || !pheo)) {
eurt();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (ishcun() && !hos && !u && dedcri() || tumac() && dedcri() || leou() && !u && dedcri() || tumac() && dedcri()) {
if (leou() && !u && dedcri() || tumac() && dedcri()) {
if (tumac() && dedcri()) {
if (dedcri()) {
return true;
}
if (!u) {
return true;
}
}
if (!hos) {
return true;
}
}
if (swis != impas()) {
return true;
}
}
return false;
return (swis != impas() || ishcun()) && (!hos || leou()) && (!u || tumac()) && dedcri();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!tumac() && u || !leou() && hos || !ishcun() && swis == impas()) {
if (!dedcri()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (fre == 9) {
hilge();
} else if (oera == false && fre != 9) {
fiaho();
} else if (ca == odmu && fre != 9 && oera != false) {
edaFobcec();
} else if (sor == nu && fre != 9 && oera != false && ca != odmu) {
tashed();
} else if (se && fre != 9 && oera != false && ca != odmu && sor != nu) {
crac();
}
if (e == true && fre != 9 && oera != false && ca != odmu && sor != nu && !se) {
iblae();
}
{
if (fre == 9) {
hilge();
}
if (!oera) {
fiaho();
}
if (ca == odmu) {
edaFobcec();
}
if (sor == nu) {
tashed();
}
if (se) {
crac();
}
if (e) {
iblae();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: