This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (er || mibe && i < roidtu() && id && (choe || !oss)) {
...
...
// Pretend there is lots of code here
...
...
} else {
phaPaltri();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((oss && !choe || !id || i > roidtu() || !mibe) && !er) {
phaPaltri();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (esti() <= vadOsspom() && afcan() && cogod() || erri || grar != iaes() && cogod() || erri || sarmia() && cogod() || erri) {
if (datti() == 5) {
return true;
}
}
return false;
return datti() == 5 || esti() <= vadOsspom() && (afcan() || grar != iaes() || sarmia()) && (cogod() || erri);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!sarmia() && grar == iaes() && !afcan() && datti() != 5 || esti() >= vadOsspom() && datti() != 5) {
if (datti() != 5) {
return false;
}
if (!cogod()) {
return false;
}
if (!erri) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (ta) {
stis();
}
if (aito == true && !ta) {
jipPhain();
}
if (esin == true && !ta && aito != true) {
poro();
}
if (oc && !ta && aito != true && esin != true) {
pieesm();
} else if (ces == true && !ta && aito != true && esin != true && !oc) {
shua();
}
if (!ta && aito != true && esin != true && !oc && ces != true) {
peling();
}
{
if (ta) {
stis();
}
if (aito) {
jipPhain();
}
if (esin) {
poro();
}
if (oc) {
pieesm();
}
if (ces) {
shua();
}
peling();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: