This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (prud == 0 && diar() && !(!clor || koma) && (id || sascri() > e)) {
...
...
// Pretend there is lots of code here
...
...
} else {
ulpas();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (sascri() < e && !id || !clor || koma || !diar() || prud != 0) {
ulpas();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (orge == 6 && amon && pu == eceall() && !ioc) {
if (o < puid) {
return true;
}
}
if (arme()) {
return true;
}
if (orel) {
return true;
}
return false;
return orel && arme() && (o < puid || orge == 6 && amon && pu == eceall() && !ioc);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!arme() || !orel) {
if (!amon && o > puid || orge != 6 && o > puid) {
if (pu != eceall() && o > puid) {
if (o > puid) {
return false;
}
if (ioc) {
return false;
}
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (zil == true) {
opsip();
} else if (phur == true && zil != true) {
prer();
}
if (!mo && zil != true && phur != true) {
oodWhahe();
} else if (pi == 9 && zil != true && phur != true && mo) {
kuuFlesa();
} else if (wium >= sor && zil != true && phur != true && mo && pi != 9) {
himcop();
} else if (erae >= he && zil != true && phur != true && mo && pi != 9 && wium <= sor) {
ciqand();
}
{
if (zil) {
opsip();
}
if (phur) {
prer();
}
if (!mo) {
oodWhahe();
}
if (pi == 9) {
kuuFlesa();
}
if (wium >= sor) {
himcop();
}
if (erae >= he) {
ciqand();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: