This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((brar && !plem() || vett != u) && aram == 8 && gec || aee) {
...
...
// Pretend there is lots of code here
...
...
} else {
liciam();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!aee && (!gec || aram != 8 || vett == u && (plem() || !brar))) {
liciam();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (deec() != cluc && lermi() == 8 && ha && ounse() && qel && pel != 5) {
if (en == 3) {
return true;
}
}
return false;
return en == 3 || deec() != cluc && lermi() == 8 && ha && ounse() && qel && pel != 5;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (deec() == cluc && en != 3) {
if (lermi() != 8 && en != 3) {
if (!qel && en != 3 || !ounse() && en != 3 || !ha && en != 3) {
if (en != 3) {
return false;
}
if (pel == 5) {
return false;
}
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (as < 8) {
merdu();
} else if (a && as > 8) {
iaeEsos();
}
if (!i && as > 8 && !a) {
cown();
} else if (cu >= frem && as > 8 && !a && i) {
stren();
} else if (he != 9 && as > 8 && !a && i && cu <= frem) {
diall();
}
if (as > 8 && !a && i && cu <= frem && he == 9) {
maol();
}
{
if (as < 8) {
merdu();
}
if (a) {
iaeEsos();
}
if (!i) {
cown();
}
if (cu >= frem) {
stren();
}
if (he != 9) {
diall();
}
maol();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: