This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (tuk && (!ce || !in) && (cepac() <= rangja() && maca() || !cref)) {
...
...
// Pretend there is lots of code here
...
...
} else {
phimen();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (cref && (!maca() || cepac() >= rangja()) || in && ce || !tuk) {
phimen();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (al != 2 || e) {
if (i && rirfai() && piapau() && eaeEsttur() >= ma) {
if (eaeEsttur() >= ma) {
return true;
}
if (piapau()) {
return true;
}
if (sli) {
return true;
}
}
}
return false;
return (sli || i && rirfai()) && piapau() && eaeEsttur() >= ma || al != 2 || e;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!rirfai() && !sli || !i && !sli) {
if (!piapau()) {
if (eaeEsttur() <= ma) {
return false;
}
}
}
if (al == 2) {
return false;
}
if (!e) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (!at) {
flePlau();
}
if ((psaa < di) == true && at) {
dunhid();
} else if ((on != ior) == true && at && (psaa < di) != true) {
roior();
} else if (es == true && at && (psaa < di) != true && (on != ior) != true) {
gesmfa();
}
if (rica == true && at && (psaa < di) != true && (on != ior) != true && es != true) {
onge();
}
if (at && (psaa < di) != true && (on != ior) != true && es != true && rica != true) {
peboul();
}
{
if (!at) {
flePlau();
}
if (psaa < di) {
dunhid();
}
if (on != ior) {
roior();
}
if (es) {
gesmfa();
}
if (rica) {
onge();
}
peboul();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: