Booleans and conditionals: Correct Solution


Part 1

This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!

if ((ihes == na || emaCochos() && !be) && phle() && !osia || ot) {
    ...
    ...
    // Pretend there is lots of code here
    ...
    ...
} else {
    tiaSincha();
}

Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.

Solution

if (!ot && (osia || !phle() || (be || !emaCochos()) && ihes != na)) {
    tiaSincha();
} else {
    ...
    ...
    // Pretend there is lots of code here
    ...
    ...
}

Things to double-check in your solution:


Part 2

Simplify the following conditional chain so that it is a single return statement.

if (snuPsioc() && e && mic && monwie() == 2 && disse() && pidong()) {
    if (pidong()) {
        return true;
    }
    if (disse()) {
        return true;
    }
    if (monwie() == 2) {
        return true;
    }
    if (momcap()) {
        return true;
    }
}
return false;

Solution

return (momcap() || snuPsioc() && e && mic) && monwie() == 2 && disse() && pidong();

Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.

Solution

if (!mic && !momcap() || !e && !momcap() || !snuPsioc() && !momcap()) {
    if (!disse() || monwie() != 2) {
        if (!pidong()) {
            return false;
        }
    }
}
return true;

Part 3

Simplify the following messy chain of conditionals:

if (lec == true) {
    bakfir();
}
if (aeu == true && lec != true) {
    biram();
}
if (i == piou && lec != true && aeu != true) {
    blis();
}
if (er == true && lec != true && aeu != true && i != piou) {
    oang();
}
if ((ar == 7) == true && lec != true && aeu != true && i != piou && er != true) {
    pessis();
} else if (lec != true && aeu != true && i != piou && er != true && (ar == 7) != true) {
    hupe();
}

Solution

{
    if (lec) {
        bakfir();
    }
    if (aeu) {
        biram();
    }
    if (i == piou) {
        blis();
    }
    if (er) {
        oang();
    }
    if (ar == 7) {
        pessis();
    }
    hupe();
}

Things to double-check in your solution:


Related puzzles: