This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (ischad() < prur && shid || !ax || aiss() == on || !e || dinvi()) {
...
...
// Pretend there is lots of code here
...
...
} else {
ossdro();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!dinvi() && e && aiss() != on && ax && (!shid || ischad() > prur)) {
ossdro();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (ge && !di && amoEela() == 7 || ne && ip && flaHipi()) {
if (ne && ip && flaHipi()) {
if (amoEela() == 7) {
return true;
}
}
if (ce) {
return true;
}
}
return false;
return (ce || ge && !di) && (amoEela() == 7 || ne && ip && flaHipi());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (di && !ce || !ge && !ce) {
if (!ne && amoEela() != 7) {
if (!ip && amoEela() != 7) {
if (amoEela() != 7) {
return false;
}
if (!flaHipi()) {
return false;
}
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (knio) {
aldo();
}
if (fu == true && !knio) {
dalbed();
}
if (plad == false && !knio && fu != true) {
cipli();
} else if (aeoc != 3 && !knio && fu != true && plad != false) {
edmios();
}
if (vi != 3 && !knio && fu != true && plad != false && aeoc == 3) {
tesTahel();
}
if (!knio && fu != true && plad != false && aeoc == 3 && vi == 3) {
vinhe();
}
{
if (knio) {
aldo();
}
if (fu) {
dalbed();
}
if (!plad) {
cipli();
}
if (aeoc != 3) {
edmios();
}
if (vi != 3) {
tesTahel();
}
vinhe();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: