This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((riom() && !a || swin) && in && !(osci() != 7) && en <= 6) {
...
...
// Pretend there is lots of code here
...
...
} else {
stac();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (en >= 6 || osci() != 7 || !in || !swin && (a || !riom())) {
stac();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (psuc != 6 || rolMosesm() || miur) {
if (iloa) {
return true;
}
}
if (rass == aucPabenk()) {
return true;
}
if (!to) {
return true;
}
if (co != pasm()) {
return true;
}
return false;
return co != pasm() && !to && rass == aucPabenk() && (iloa || psuc != 6 || rolMosesm() || miur);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (rass != aucPabenk() || to || co == pasm()) {
if (!iloa) {
return false;
}
if (psuc == 6) {
return false;
}
if (!rolMosesm()) {
return false;
}
if (!miur) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (une == true) {
sparl();
} else if (uin == true && une != true) {
irzuss();
} else if (oudi != ow && une != true && uin != true) {
casess();
} else if (oass >= 6 && une != true && uin != true && oudi == ow) {
privi();
}
if (we == true && une != true && uin != true && oudi == ow && oass <= 6) {
godad();
}
if (une != true && uin != true && oudi == ow && oass <= 6 && we != true) {
prapsi();
}
{
if (une) {
sparl();
}
if (uin) {
irzuss();
}
if (oudi != ow) {
casess();
}
if (oass >= 6) {
privi();
}
if (we) {
godad();
}
prapsi();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: